Conversation
…er function events
…isWindow into GLVisCommand
| face_has_kerning(false) | ||
| face_has_kerning(false), | ||
| is_hidpi(false), | ||
| ppi_w(96), ppi_h(96) |
There was a problem hiding this comment.
(minor) these could be default values when the members are declared:
... etc ...
bool face_has_kerning = false;
bool is_hidpi = false;
int ppi_w = 96, ppi_h = 96;
|
I can now build and run the js version but there is at least on thing that isn't working yet. I saw that the
Instead of this:
I'll spend some more time debugging. |
closer to working but not quite there
…is is happening yet but reusing the existing GLVisWindow does the trick (and is what we were doing previously)
|
The JS target seems to work well for me now, I slacked a copy to @tzanio and @kanye-quest so check it out if you want |
|
All other examples from glvis.org/live work for me, but I still get an error with Navier in this branch, e.g. the following run: shows
instead of
|
| } | ||
|
|
||
| if (input_streams.Size() > 0) | ||
| catch (std::runtime_error& ex) |
There was a problem hiding this comment.
I think this may be the first use of exceptions in MFEM or GLVis 😁
| continue; | ||
| } | ||
|
|
||
|
|
3 participants
This PR is intended to split off some of the work from #149 into a somewhat-smaller PR.
GLVisWindow, which consolidates most of the global state withinaux_vis.cpp.GLVisWindowhandles creation of theSdlWindow,VisualizationScene*, andGLVisCommandobjects from aStreamStateobject and/or an array of input streams.VisualizationScene*event handlers member functions where possible, removing dependence on global pointers.GLVisCommandand other idle function runs fromSdlWindowtoGLVisWindow.